refactor(torii-server): combine tonic
and warp
#926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the
warp
server to allow for better request forwarding of gRPC requests. Instead of usingwarp
to combine these two services, this PR useshyper
.The server accepts the requests and check the base path of the URI, if
base_path == '/grpc'
, then it strip the base path and forward it to thetonic
server. Otherwise, it forwards it towarp
.torii-grpc
's serverwarp
route has been removed.IMPORTANT NOTE
tonic
client where the URI path is not respected inEndpoint
, but this issue doesn't exist iftorii-client
is compiled towasm32-unknown-unknown
. Meaning, if the gRPC requests are sent from non-wasm3-unknown-unknown
build, then, the request URI would belocalhost:8080/
even though in the client code you have setlocalhost:8080/grpc
.See: hyperium/tonic#1314
insomnia
, I keep getting name resolution error: