-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(katana): use the exact same UDC class as Starknet #2949
Conversation
WalkthroughOhayo, sensei! The pull request focuses on refactoring the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
=======================================
Coverage 55.86% 55.86%
=======================================
Files 447 447
Lines 57859 57859
=======================================
Hits 32323 32323
Misses 25536 25536 ☔ View full report in Codecov by Sentry. |
The UDC class that is currently being used hash a class hash of
0x035e13e8852c6fc49a9d87f9448079f69d6dae1795fe64e8a737eab8fd24dcb0
while the one that Starknet is officially using has the class hash of0x07b3e05f48f0c69e4a65ce5e076a66271a527aff2c34ce1083ec6e1526997a69
.The updated UDC class is exactly the same as the one used by Starknet therefore will result in the same class hash when it is computed. It is not an issue currently because we're hardcoding the class hash ourselves when it is inserted in the genesis. But we're moving away from allowing hardcoded class hash to maintain correctness.
The reason why we want to use the same version is to maintain compatibility and predictability across libs.
This doesn't introduce any breaking changes as the hardcoded class hash is the correct one for the new class.