Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii-grpc): start rework to use 1 single query #2817

Merged
merged 23 commits into from
Dec 21, 2024

tests: fix by passing the list of expected models

feecbdb
Select commit
Loading
Failed to load commit list.
Merged

feat(torii-grpc): start rework to use 1 single query #2817

tests: fix by passing the list of expected models
feecbdb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 21, 2024 in 0s

56.28% (+0.35%) compared to c0b8033

View this Pull Request on Codecov

56.28% (+0.35%) compared to c0b8033

Details

Codecov Report

Attention: Patch coverage is 37.86408% with 128 lines in your changes missing coverage. Please review.

Project coverage is 56.28%. Comparing base (c0b8033) to head (feecbdb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/grpc/src/server/mod.rs 27.84% 127 Missing ⚠️
crates/torii/core/src/sql/cache.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
+ Coverage   55.92%   56.28%   +0.35%     
==========================================
  Files         439      439              
  Lines       56156    56276     +120     
==========================================
+ Hits        31408    31677     +269     
+ Misses      24748    24599     -149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.