fix(torii-grpc): address sql precedence in composite

[Larkooo]

Summary by CodeRabbit

• New Features

  • Improved SQL query handling with enhanced clarity in logical grouping.
  • Updated subscription and streaming response management for better handling of multiple subscriptions.

• Bug Fixes

  • Enhanced error handling mechanisms for clearer error reporting in entity and event retrieval.

• Documentation

  • Method signatures updated for clarity in public API.

[coderabbitai]

Warning

Rate limit exceeded

@Larkooo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 09b2157 and 744f6a9.

📒 Files selected for processing (1)

• crates/torii/grpc/src/server/mod.rs (5 hunks)

Walkthrough

Ohayo, sensei! This pull request introduces several modifications to the DojoWorld struct within the crates/torii/grpc/src/server/mod.rs file. Key updates involve enhancements to SQL query construction, particularly in the build_composite_clause function, ensuring proper formatting of WHERE and HAVING clauses. Additionally, error handling improvements are made in the retrieve_entities and retrieve_events methods, along with modifications to subscription and streaming methods, ensuring effective management of multiple subscriptions and clearer error reporting.

Changes

File Path	Change Summary
crates/torii/grpc/src/server/mod.rs	- Updated SQL query construction in build_composite_clause for better clause formatting.
	- Enhanced error handling in retrieve_entities and retrieve_events methods.
	- Modified subscribe_entities, subscribe_event_messages, and retrieve_entities_streaming methods for improved subscription and streaming logic.

Possibly related PRs

• refactor: member clauses handle struct fields & operators & recursive #2420: Refactors the DojoWorld implementation and introduces a new method for constructing SQL clauses, related to build_composite_clause.
• refactor-opt(torii-grpc): subscriptions no db fetch #2455: Modifies subscription handling in the DojoWorld struct, relevant to subscription method updates.
• refactor(torii-grpc): event subscription with multiple clauses #2555: Enhances subscription logic by allowing multiple entity keys, connecting to modifications in subscription handling.
• fix: keys composite clause #2798: Updates the build_keys_pattern and build_composite_clause functions, directly related to SQL query construction changes.

Suggested reviewers

• glihm

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.74%. Comparing base (91c76d9) to head (744f6a9).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torii/grpc/src/server/mod.rs	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2800      +/-   ##
==========================================
- Coverage   55.74%   55.74%   -0.01%     
==========================================
  Files         439      439              
  Lines       55571    55572       +1     
==========================================
  Hits        30978    30978              
- Misses      24593    24594       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.