Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii-core): json value for ty for efficient json ser #2730
feat(torii-core): json value for ty for efficient json ser #2730
Changes from 3 commits
0085a79
5b8c77c
bc56e52
22fe5e4
fd49da8
30938be
2487b19
8362198
c7a3708
d4ecbb9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle empty arrays safely
The current implementation assumes arrays are non-empty and could panic when deserializing an empty array.
Apply this fix:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improving Error Handling in
from_json_value
The
from_json_value
method effectively deserializes JSON values intoTy
instances. However, there are several areas where error handling can be enhanced to prevent silent failures.Handle parsing errors for numeric primitives
Ohayo sensei, when parsing numeric values from JSON, assigning
None
on failure may lead to unexpected behavior. It's better to return an error if parsing fails.Example modification for
Primitive::I64
(lines 396-398):Apply similar changes for other numeric primitives (
I128
,U64
,U128
), ensuring that parsing errors are properly propagated.Ensure proper error handling for
Primitive::U256
parsingIn lines 436-449, when parsing
high
andlow
values, failure to parse should result in an error rather than being silently ignored.Consistent error handling across all primitive types will enhance the robustness of the deserialization process.
📝 Committable suggestion