Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fee token to TransactionOption and TxnConfig #2650

Merged
merged 5 commits into from
Nov 7, 2024

fix: add v3 to multicall and display better error for validation error

db7f4d3
Select commit
Loading
Failed to load commit list.
Merged

feat: add fee token to TransactionOption and TxnConfig #2650

fix: add v3 to multicall and display better error for validation error
db7f4d3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 1s

57.85% (+0.51%) compared to a4adeb3

View this Pull Request on Codecov

57.85% (+0.51%) compared to a4adeb3

Details

Codecov Report

Attention: Patch coverage is 64.07767% with 74 lines in your changes missing coverage. Please review.

Project coverage is 57.85%. Comparing base (a4adeb3) to head (db7f4d3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/dojo/utils/src/tx/mod.rs 40.00% 39 Missing ⚠️
bin/sozo/src/commands/options/transaction.rs 84.68% 17 Missing ⚠️
crates/dojo/utils/src/tx/invoker.rs 28.57% 10 Missing ⚠️
crates/dojo/utils/src/tx/declarer.rs 55.55% 4 Missing ⚠️
crates/dojo/utils/src/tx/error.rs 0.00% 2 Missing ⚠️
bin/sozo/src/commands/migrate.rs 0.00% 1 Missing ⚠️
crates/dojo/utils/src/tx/deployer.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
+ Coverage   57.34%   57.85%   +0.51%     
==========================================
  Files         399      399              
  Lines       49747    49806      +59     
==========================================
+ Hits        28527    28816     +289     
+ Misses      21220    20990     -230

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov