Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(katana): remove unused codes #2647

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore(katana): remove unused codes #2647

merged 1 commit into from
Nov 6, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Nov 6, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced KatanaRunner with new configuration options for log file path and database directory.
    • Improved error handling for subprocess operations.
  • Bug Fixes

    • Removed unnecessary dependencies to streamline the package.
  • Chores

    • Deleted obsolete logging functionality to simplify the codebase.

Copy link

coderabbitai bot commented Nov 6, 2024

Walkthrough

Ohayo, sensei! This pull request introduces several changes to the katana-runner package. Key modifications include the removal of specific dependencies from the Cargo.toml file, enhancing the KatanaRunner struct with new fields, and updating the associated configuration struct. The logging functionality has been completely removed, including related structures and methods. Overall, the changes streamline the package's dependencies and adjust its configuration capabilities while eliminating logging features.

Changes

File Path Change Summary
crates/katana/runner/Cargo.toml Removed dependencies: chrono, serde, serde_json. Retained other dependencies with workspace settings.
crates/katana/runner/src/lib.rs Updated KatanaRunner struct to include log_file_path and contract. Updated KatanaRunnerConfig to include db_dir. Modified setup_and_start to handle new configuration options. Added log_file_path method. Improved error handling with anyhow.
crates/katana/runner/src/logs.rs Removed entire file, including TimedLog, Message structs, type alias Log, and associated methods for log handling.

Possibly related PRs

  • Improve Katana runner macro #2464: Modifications to the Cargo.toml file for the katana-runner package involve changes to dependencies, directly relating to the removal of dependencies in the main PR's Cargo.toml.
  • test(katana-rpc): don't use binary runner in katana tests #2525: The removal of the katana-runner dependency from the katana-rpc package's Cargo.toml indicates a shift in how the runner is utilized, aligning with the overall changes in dependency management seen in the main PR.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 884a726 and 58d667a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • crates/katana/runner/Cargo.toml (0 hunks)
  • crates/katana/runner/src/lib.rs (0 hunks)
  • crates/katana/runner/src/logs.rs (0 hunks)
💤 Files with no reviewable changes (3)
  • crates/katana/runner/Cargo.toml
  • crates/katana/runner/src/lib.rs
  • crates/katana/runner/src/logs.rs

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.35%. Comparing base (884a726) to head (58d667a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
+ Coverage   57.24%   57.35%   +0.10%     
==========================================
  Files         400      399       -1     
  Lines       49826    49747      -79     
==========================================
+ Hits        28525    28531       +6     
+ Misses      21301    21216      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit a4adeb3 into main Nov 6, 2024
14 checks passed
@kariy kariy deleted the katana/remove-unused branch November 6, 2024 20:16
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant