refactor: apply code simplification to break with bool value (n-04)

[glihm]

Summary by CodeRabbit

• Bug Fixes

  • Improved the clarity and efficiency of the name validation process without altering its functionality. This enhancement ensures that users can continue to validate names effectively while benefiting from a more streamlined codebase.

• Configuration Updates

  • Updated the world_address in the configuration file to a new value, ensuring the application connects to the correct environment.

• Target Updates

  • Modified multiple target values for various methods to ensure accurate functionality, enhancing overall application performance.

[coderabbitai]

Walkthrough

Ohayo, sensei! The changes in this pull request involve a modification to the is_name_valid function in crates/dojo/core/src/utils/naming.cairo. The function's control flow has been streamlined by replacing an explicit conditional check with a single break statement that directly returns the result of the condition. This adjustment simplifies the function while maintaining its original logic of validating names against a regular expression. Additionally, the world_address field in the dojo_dev.toml configuration file has been updated to a new value. The policies.json file has also seen numerous updates to the target addresses associated with various methods.

Changes

File Path	Change Summary
crates/dojo/core/src/utils/naming.cairo	Modified is_name_valid function to simplify control flow by replacing nested if with a single break statement. Function signature remains unchanged.
examples/spawn-and-move/dojo_dev.toml	Updated world_address in section [env] from 0x54d0f13bf3fb5f15a8674c5204aad35e3022af96bcc23bdbd16b7e297ffd399 to 0x70058e3886cb7411e8a77db90ee3dd453ac16b763b30bd99b3c8440fe42056e.
bin/sozo/tests/test_data/policies.json	Updated target addresses for multiple methods, replacing old addresses with new ones while maintaining the overall JSON structure. Added new target addresses for __declare_transaction__ and deployContract.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NamingUtils

    User->>NamingUtils: Call is_name_valid(name)
    NamingUtils->>NamingUtils: Validate name using regex
    NamingUtils-->>User: Return true/false based on validation

Loading

Possibly related PRs

• fix: use name for contract interface to be consistent #2482: The changes in this PR involve renaming the contract_name method to name in the IContract trait, which is related to naming conventions similar to the changes made in the main PR's is_name_valid function.
• fix(lang): change the upgrade contract salt to allow multicall #2617: This PR modifies the upgrade_contract function to change how the contract salt is calculated, which may relate to the overall naming and identification of contracts, similar to the focus on valid names in the main PR.
• feat: separate the resource registration and permission phase for tes… #2627: The separation of resource registration and permission phases in this PR aligns with the main PR's focus on improving clarity and functionality in naming conventions, as both aim to enhance code structure and readability.
• refactor(lang): update convention for keys and values naming  #2660: This PR updates naming conventions for keys and values, which directly relates to the main PR's changes in the is_name_valid function, emphasizing consistency in naming across the codebase.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c6a6f29 and fa13d92.

⛔ Files ignored due to path filters (2)

• spawn-and-move-db.tar.gz is excluded by !**/*.gz
• types-test-db.tar.gz is excluded by !**/*.gz

📒 Files selected for processing (1)

• bin/sozo/tests/test_data/policies.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• bin/sozo/tests/test_data/policies.json

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.31%. Comparing base (0bd03bb) to head (fa13d92).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
- Coverage   57.32%   57.31%   -0.01%     
==========================================
  Files         401      401              
  Lines       50543    50543              
==========================================
- Hits        28972    28971       -1     
- Misses      21571    21572       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.