Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii): model upgrades #2637
feat(torii): model upgrades #2637
Changes from 14 commits
b1f3e35
fa71dbd
60a870d
62750f6
6313f44
f7fd6ae
e85bdd0
d641ba0
3336c4a
3742676
b3ee109
0d26d43
cbc39c7
14ffc8e
ddd9921
cf9c45c
3925cce
ae8bf42
210ac31
d86fcc4
ab855dd
5d57e6d
b04e848
e3d8a7b
b7f3264
87857c2
9b5d624
9ac0d21
a8d6737
d2c7696
255d4fb
6235080
612fc4b
0dbec7e
551c6bd
cea8102
155033d
4e921c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Handle unexpected event types explicitly
Ohayo, sensei! Instead of using
unreachable!()
, return an error when an unexpected event type is encountered. This improves code robustness and makes debugging easier.Apply this diff:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace panic and unreachable with proper error handling
Ohayo sensei! The current error handling could crash the application. Consider using proper error propagation:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might rework the
model.schema()
to accept a block id, which could perhaps be more accurate at some point when replaying history.But not a blocker for this V1.