Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): switch base image to busybox #2605

Closed
wants to merge 1 commit into from
Closed

ci(docker): switch base image to busybox #2605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RUN git clone https://github.com/Comcast/Infinite-File-Curtailer.git curtailer \
&& make install \
&& curtail --version

FROM debian:bookworm-slim as base
FROM busybox as base

COPY --from=builder /usr/bin/tini /tini
ENTRYPOINT ["/tini", "--"]
Comment on lines 19 to 20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ohayo sensei! Consider adding a non-root user.

While the tini setup is correct, running as root in containers is a security risk. Consider adding:

FROM gcr.io/distroless/base as base

+ USER nonroot:nonroot
COPY --from=builder /usr/bin/tini /tini
ENTRYPOINT ["/tini", "--"]

Committable suggestion skipped: line range outside the PR's diff.

Expand Down
Loading