Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii): fetch and process erc721 metadata and image #2544

Closed
wants to merge 1 commit into from

Conversation

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 13.50575% with 602 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (1a61255) to head (042ac6a).

Files with missing lines Patch % Lines
crates/torii/core/src/executor.rs 13.17% 257 Missing ⚠️
crates/torii/server/src/artifacts.rs 0.00% 236 Missing ⚠️
bin/torii/src/main.rs 0.00% 36 Missing ⚠️
crates/torii/server/src/proxy.rs 0.00% 29 Missing ⚠️
crates/torii/core/src/sql/erc.rs 0.00% 28 Missing ⚠️
crates/torii/core/src/utils.rs 68.42% 6 Missing ⚠️
crates/torii/core/src/sql/mod.rs 0.00% 5 Missing ⚠️
...orii/core/src/processors/erc721_legacy_transfer.rs 0.00% 2 Missing ⚠️
...rates/torii/core/src/processors/erc721_transfer.rs 0.00% 2 Missing ⚠️
...rates/torii/core/src/processors/metadata_update.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           spr/main/bc10539f    #2544      +/-   ##
=====================================================
- Coverage              69.30%   68.77%   -0.53%     
=====================================================
  Files                    402      403       +1     
  Lines                  51070    51567     +497     
=====================================================
+ Hits                   35392    35466      +74     
- Misses                 15678    16101     +423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x lambda-0x force-pushed the spr/main/274aaa3a branch 4 times, most recently from 2b703a2 to 624919a Compare October 23, 2024 10:12
@lambda-0x lambda-0x marked this pull request as ready for review October 23, 2024 10:12
@rsodre
Copy link

rsodre commented Oct 23, 2024

There should be a way to notify Torii that metadata needs to be updated.

I opened an issue on OpenZeppelin to add ERC-4906, which implements the MetadataUpdate and BatchMetadataUpdate events, just for that.

I'm available to hurry it on the OZ side so we can add support to Torii.

crates/torii/core/src/executor.rs Outdated Show resolved Hide resolved
crates/torii/core/src/executor.rs Outdated Show resolved Hide resolved
crates/torii/core/src/executor.rs Outdated Show resolved Hide resolved
@lambda-0x
Copy link
Contributor Author

✓ Commit merged in pull request #2689

@lambda-0x lambda-0x closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants