rm useless #[allow(deprecated)]

[tcoratger]

Summary by CodeRabbit

• New Features

  • Introduced methods for fee estimation and transaction simulation in the Starknet API.
  • Added estimate_fee and estimate_message_fee methods for enhanced transaction processing.
  • New simulate_txs method for simulating transactions based on user-defined parameters.

• Bug Fixes

  • Improved error handling and filtering for block and transaction retrieval methods.

• Deprecation Notices

  • Marked predeployed_accounts method as deprecated for backward compatibility.

[coderabbitai]

Walkthrough

Ohayo, sensei! This pull request introduces several modifications across different files. The TestSequencer struct has had its deprecated attributes removed from specific methods, while the DevApi struct has marked a method as deprecated for backward compatibility. Additionally, new methods for fee estimation have been added to the StarknetApiServer, and the StarknetApi has been enhanced with new transaction simulation methods. Overall, these changes reflect a shift in handling deprecated features and an expansion of API capabilities.

Changes

File Path	Change Summary
crates/dojo-test-utils/src/sequencer.rs	Removed #[allow(deprecated)] from start and account_at_index methods in TestSequencer.
crates/katana/rpc/rpc/src/dev.rs	Marked predeployed_accounts method as deprecated with #[allow(deprecated)] in DevApi.
crates/katana/rpc/rpc/src/starknet/read.rs	Added estimate_fee and estimate_message_fee methods to StarknetApiServer.
crates/katana/rpc/rpc/src/starknet/trace.rs	Added simulate_txs, block_traces, and trace methods; updated existing methods for better handling.

Possibly related issues

• remove SequencerConfig usage #2467: The changes in this PR relate to the removal of deprecated features, which aligns with the objective of fully deprecating SequencerConfig usage.

Possibly related PRs

• Improve Katana runner macro #2464: Modifications to the katana_runner macro are relevant to the updates on the TestSequencer struct and its methods.
• chore: use the new Katana runner proc macro #2465: Focuses on utilizing the new Katana runner proc macro, which aligns with changes in the TestSequencer struct.
• feat(katana-rpc): add traceTransaction and traceBlockTransactions API #2486: Adds new API methods and modifies the TxExecInfo struct, potentially relating to transaction handling in the context of TestSequencer.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9a1e300 and 2eda166.

📒 Files selected for processing (4)

• crates/dojo-test-utils/src/sequencer.rs (0 hunks)
• crates/katana/rpc/rpc/src/dev.rs (0 hunks)
• crates/katana/rpc/rpc/src/starknet/read.rs (0 hunks)
• crates/katana/rpc/rpc/src/starknet/trace.rs (0 hunks)

💤 Files with no reviewable changes (4)

• crates/dojo-test-utils/src/sequencer.rs
• crates/katana/rpc/rpc/src/dev.rs
• crates/katana/rpc/rpc/src/starknet/read.rs
• crates/katana/rpc/rpc/src/starknet/trace.rs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (9a1e300) to head (2eda166).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   68.57%   68.60%   +0.03%     
==========================================
  Files         387      387              
  Lines       49990    49988       -2     
==========================================
+ Hits        34280    34295      +15     
+ Misses      15710    15693      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.