-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii-core): bitflags for indexing #2450
Conversation
WalkthroughOhayo, sensei! The changes introduce new command-line arguments for indexing transactions and raw events in the application. Two boolean flags, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant Engine
participant RPC
User->>CLI: Execute application with flags
CLI->>Engine: Pass indexing flags
Engine->>RPC: Fetch transactions (if index_transactions is true)
Engine->>RPC: Fetch events (if index_raw_events is true)
Engine-->>User: Return results
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2450 +/- ##
==========================================
- Coverage 68.37% 68.29% -0.08%
==========================================
Files 365 365
Lines 47973 48034 +61
==========================================
+ Hits 32801 32805 +4
- Misses 15172 15229 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have this configurable.
Indexing events by default nice, should we expose back then using graphQL and gRPC?
Summary by CodeRabbit
New Features
IndexingFlags
structure for improved configuration of indexing options.Improvements
Dependencies
clap
andbitflags
.