opt(katana): graceful shutdown on SIGTERM

[kariy]

Summary by CodeRabbit

• New Features

  • Enhanced signal handling capabilities, allowing the application to respond to various termination signals (Ctrl+C and termination requests) for more robust shutdown procedures.
  • Introduced a new asynchronous function to manage signal listening effectively.

• Documentation

  • Updated comments to reflect the broader capabilities of the new signal handling mechanism.

[coderabbitai]

Walkthrough

Ohayo, sensei! The recent changes focus on enhancing the signal handling mechanism within the application. The NodeArgs implementation in node.rs has been updated to utilize a new wait_signal function, replacing the previous direct handling of the ctrl_c signal. Additionally, a new asynchronous function wait_signal has been introduced in the utils module to handle termination signals like SIGINT and SIGTERM, improving the application's capability to manage shutdown procedures.

Changes

File Path	Change Summary
bin/katana/src/cli/node.rs	Replaced direct ctrl_c signal handling with wait_signal function for improved signal management.
bin/katana/src/utils.rs	Added wait_signal function to handle SIGINT and SIGTERM, improving termination signal handling.

Possibly related PRs

• opt(katana): graceful shutdown on critical tasks termination #2409: This PR enhances the shutdown logic in node.rs by allowing the application to respond to multiple shutdown signals, which is directly related to the changes made in the main PR regarding signal handling.
• fix(katana-tasks): ensure is cancelled before waiting on shutdown #2412: This PR modifies the shutdown method in the TaskManager to ensure tasks are cancelled before shutdown, which complements the broader signal handling improvements introduced in the main PR.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0e2c99c and 6c5e258.

Files selected for processing (1)

• bin/katana/src/cli/node.rs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• bin/katana/src/cli/node.rs

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.03%. Comparing base (069bc1a) to head (6c5e258).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
bin/katana/src/utils.rs	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   67.89%   68.03%   +0.14%     
==========================================
  Files         364      364              
  Lines       47927    47871      -56     
==========================================
+ Hits        32539    32569      +30     
+ Misses      15388    15302      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.