refactor(torii): queries for them to not block #2391
Conversation
lambda-0x
force-pushed
the
spr/main/6c5aebce
branch
2 times, most recently
from
9988fdb to
e1f12c7
Compare
commit-id:6c5aebce
lambda-0x
force-pushed
the
spr/main/6c5aebce
branch
from
e1f12c7 to
6cca479
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spr/main/b4b488fe #2391 +/- ##
=====================================================
+ Coverage 68.28% 68.30% +0.02%
=====================================================
Files 357 357
Lines 47257 47310 +53
=====================================================
+ Hits 32270 32316 +46
- Misses 14987 14994 +7 ☔ View full report in Codecov by Sentry. |
|
|
||
| update_entity.updated_model = Some(wrapped_ty); | ||
| self.query_queue.push_publish(BrokerMessage::EntityUpdated(update_entity)); | ||
| self.query_queue.push_publish_query( |
There was a problem hiding this comment.
We should ensure that set_model_member also works when parallelized
There was a problem hiding this comment.
any reason it wouldn't work?
| @@ -291,6 +292,7 @@ impl<P: Provider + Sync> Relay<P> { | |||
| peer_id = %peer_id, | |||
| "Message set." | |||
| ); | |||
| self.db.execute().await.unwrap(); | |||
There was a problem hiding this comment.
We should also execute the queries for the set_entity that is further down. Can we refactor the logic here to reuse the same self.db.execute() everywhere? We can add a function that sets the entity and directrly executes the db queries
|
while trying to test syncing the flippyflop world noticed that we are spending alot of time for poseidon hash calculation. will have to add a cache for it. |
|
closing in favour of #2397 |
Stack: