-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure we check registered model and not declared models #2368
Conversation
WalkthroughOhayo, sensei! The changes involve a significant update to the model registration logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Migration
participant ModelRegistry
User->>Migration: Initiate model registration
Migration->>ModelRegistry: Check unregistered models
ModelRegistry-->>Migration: Return unregistered models
Migration->>ModelRegistry: Register models
ModelRegistry-->>Migration: Return models_to_register
Migration-->>User: Output registration results
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
==========================================
- Coverage 67.63% 67.63% -0.01%
==========================================
Files 359 359
Lines 46977 46978 +1
==========================================
Hits 31775 31775
- Misses 15202 15203 +1 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
Bug Fixes
Refactor