Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libp2p): websocket transport #2347

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Aug 26, 2024

Summary by CodeRabbit

  • New Features

    • Introduced support for WebSocket and WebSocket Secure (WSS) transport, enhancing connectivity options.
    • Added new dependencies to improve WebSocket communication and DNS resolution capabilities.
  • Improvements

    • Updated existing dependencies to include additional features, increasing functionality and security in the communication layer.
    • Enhanced the RelayClient to dynamically incorporate the package version, improving maintainability and flexibility.

Copy link

coderabbitai bot commented Aug 26, 2024

Walkthrough

Ohayo, sensei! The changes involve updates to the Cargo.toml file in the crates/torii/libp2p project, introducing new dependencies and enhanced features for WebSocket and DNS support. The mod.rs file is modified to implement WebSocket Secure (WSS) transport alongside existing WebRTC transport, including new logic for handling secure connections and certificate generation. A new listening address for WSS is also set up to allow incoming connections. The RelayClient is updated to dynamically use the package version and support WebSocket transport.

Changes

Files Change Summary
crates/torii/libp2p/Cargo.toml Added rcgen dependency; updated libp2p features to include websocket and dns; added libp2p-websocket-websys dependency.
crates/torii/libp2p/src/server/mod.rs Implemented WebSocket Secure (WSS) transport; added imports for WebSocket and DNS; created TLS configuration using rcgen. New listening address for WSS defined.
crates/torii/libp2p/src/client/mod.rs Updated identify behavior to use dynamic package version; added WebSocket transport configuration in with_other_transport method.
crates/torii/libp2p/src/tests.rs Modified relay_server initialization in tests to change relay server configuration.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Relay
    participant WebSocket
    participant DNS

    Client->>Relay: Initiate connection
    Relay->>WebSocket: Establish WebSocket transport
    Relay->>DNS: Resolve hostname
    DNS-->>Relay: Provide IP address
    Relay-->>Client: Connection established over WSS
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6426d1e and a03dca9.

Files selected for processing (1)
  • crates/torii/libp2p/src/client/mod.rs (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • crates/torii/libp2p/src/client/mod.rs

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.52%. Comparing base (f9606d8) to head (a03dca9).
Report is 2 commits behind head on main.

Files Patch % Lines
bin/torii/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
+ Coverage   67.27%   67.52%   +0.24%     
==========================================
  Files         357      359       +2     
  Lines       46649    46867     +218     
==========================================
+ Hits        31383    31646     +263     
+ Misses      15266    15221      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.unwrap(),
);

let rcgen_cert =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Larkooo do we need to provision our own certs here?

@tarrencev tarrencev merged commit 3d8b3ba into dojoengine:main Aug 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants