refactor: switch webrtc protocol to tcp

[Larkooo]

Summary by CodeRabbit

• New Features

  • Simplified connection setup by using a single port for both TCP and WebRTC functionalities.
  • Enhanced listening address configuration for improved connection management.

• Bug Fixes

  • Resolved potential complications arising from separate WebRTC port handling.

[coderabbitai]

Walkthrough

Ohayo, sensei! The recent changes involve the removal of the port_webrtc parameter from the Relay struct's constructor. This parameter has been replaced with the existing port variable, which now accommodates both TCP and WebRTC functionalities. Consequently, the constructor has fewer parameters, and the listening address configuration has been streamlined to utilize a single port for both connection types.

Changes

Files	Change Summary
crates/torii/libp2p/src/server/mod.rs	Removed the port_webrtc parameter from the Relay struct's constructor, consolidating it with port. Updated the constructor signature accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Relay
    participant Provider
    Client->>Relay: Connect(port)
    Relay->>Provider: Handle connection
    Provider-->>Relay: Connection established
    Relay-->>Client: Connection confirmed

Loading

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b2ce5ef and e046836.

Files selected for processing (1)

• crates/torii/libp2p/src/server/mod.rs (2 hunks)

Additional comments not posted (2)

crates/torii/libp2p/src/server/mod.rs (2)

Line range hint 22-27: Ohayo sensei! Simplified constructor looks good.

The removal of the port_webrtc parameter simplifies the constructor and reduces the number of parameters.

The code changes are approved.

---

138-140: Ohayo sensei! Consolidated listening address configuration looks good.

The listen_addr_webrtc address configuration now uses the port variable, which simplifies the code and ensures consistency.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

---

Ohayo sensei! Function signature verification complete.

The calls to Relay::new in the codebase match the new signature as expected. The function is used consistently in both main.rs and tests.rs with the appropriate number of arguments. Everything looks good!

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `Relay::new` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type rust -A 5 $'Relay::new'

Length of output: 779

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[glihm]

What was the main motivation to switch, firewall?