-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(katana-executor): katana to blockifier chain id invariant #2204
Conversation
WalkthroughOhayo, sensei! This update refines the test functions in the Changes
Sequence Diagram(s)sequenceDiagram
participant Test
participant Blockifier
participant ChainId
Test->>Blockifier: Call with chain ID
Blockifier->>ChainId: Retrieve corresponding chain ID
ChainId-->>Blockifier: Return MAINNET or SEPOLIA
Blockifier-->>Test: Validate chain ID consistency
This diagram illustrates the interaction between the test, blockifier, and chain ID retrieval process. Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 68.18% 68.20% +0.01%
==========================================
Files 336 336
Lines 44038 44056 +18
==========================================
+ Hits 30029 30048 +19
+ Misses 14009 14008 -1 ☔ View full report in Codecov by Sentry. |
add invariant test for issue on chain id
Closes #1595.
Summary by CodeRabbit
Bug Fixes
New Features