Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove starknet_in_rust executor support #2200

Merged
merged 2 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ jobs:
chmod +x /tmp/bins/katana
KATANA_RUNNER_BIN=/tmp/bins/katana cargo llvm-cov nextest --no-report --all-features --workspace --exclude katana --build-jobs 20
cargo llvm-cov nextest --no-report -p katana
# TODO(kariy): uncomment this line when `sir` feature support Cairo 2.6.3
# cargo llvm-cov nextest --no-report -p katana --no-default-features --features sir
cargo llvm-cov report --lcov --output-path lcov.info
- uses: codecov/codecov-action@v4
with:
Expand Down
12 changes: 4 additions & 8 deletions bin/katana/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ common.workspace = true
console.workspace = true
dojo-metrics.workspace = true
katana-core.workspace = true
katana-executor.workspace = true
katana-executor = { workspace = true, features = [ "blockifier" ] }
katana-primitives.workspace = true
katana-rpc-api.workspace = true
katana-rpc.workspace = true
katana-rpc-api.workspace = true
serde_json.workspace = true
shellexpand = "3.1.0"
tokio.workspace = true
tracing-subscriber.workspace = true
tracing.workspace = true
tracing-subscriber.workspace = true
url.workspace = true

katana-slot-controller = { workspace = true, optional = true }
Expand All @@ -32,11 +32,7 @@ katana-slot-controller = { workspace = true, optional = true }
assert_matches.workspace = true

[features]
default = [ "blockifier", "jemalloc", "messaging", "slot" ]

blockifier = [ "katana-executor/blockifier" ]
# Disable until SIR support Cairo 2.6.3
#sir = [ "katana-executor/sir" ]
default = [ "jemalloc", "messaging", "slot" ]

jemalloc = [ "dojo-metrics/jemalloc" ]
messaging = [ "katana-core/messaging" ]
Expand Down
15 changes: 0 additions & 15 deletions bin/katana/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,6 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
..Default::default()
};

// TODO: Uncomment this once we enable the 'sir' feature again because it's not compatible with
// our current Cairo version (2.6.3). cfg_if::cfg_if! {
// if #[cfg(all(feature = "blockifier", feature = "sir"))] {
// compile_error!("Cannot enable both `blockifier` and `sir` features at the same
// time"); } else if #[cfg(feature = "blockifier")] {
// use katana_executor::implementation::blockifier::BlockifierFactory;
// let executor_factory = BlockifierFactory::new(cfg_env, simulation_flags);
// } else if #[cfg(feature = "sir")] {
// use katana_executor::implementation::sir::NativeExecutorFactory;
// let executor_factory = NativeExecutorFactory::new(cfg_env, simulation_flags);
// } else {
// compile_error!("At least one of the following features must be enabled: blockifier,
// sir"); }
// }

use katana_executor::implementation::blockifier::BlockifierFactory;
let executor_factory = BlockifierFactory::new(cfg_env, simulation_flags);

Expand Down
8 changes: 0 additions & 8 deletions crates/katana/executor/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ tracing.workspace = true
blockifier = { git = "https://github.com/dojoengine/blockifier", branch = "cairo-2.7", features = [ "testing" ], optional = true }
katana-cairo = { workspace = true, optional = true }

# Disable SIR for now until they support Cairo 2.6.3
# # starknet_in_rust deps
# cairo-lang-sierra = { workspace = true, optional = true }
# sir = { package = "starknet_in_rust", git = "https://github.com/dojoengine/starknet_in_rust.git", rev = "601a65e", optional = true }
# starknet-types-core = { version = "0.0.9", optional = true }

[dev-dependencies]
alloy-primitives.workspace = true
anyhow.workspace = true
Expand All @@ -44,8 +38,6 @@ rayon.workspace = true
[features]
blockifier = [ "dep:blockifier", "dep:katana-cairo", "dep:starknet" ]
default = [ "blockifier" ]
# native = [ "sir", "sir/cairo-native" ]
# sir = [ "dep:sir", "dep:starknet-types-core" ]

[[bench]]
harness = false
Expand Down
4 changes: 0 additions & 4 deletions crates/katana/executor/src/implementation/mod.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
#[cfg(feature = "blockifier")]
pub mod blockifier;

// #[cfg(feature = "sir")]
// pub mod sir;

pub mod noop;
43 changes: 0 additions & 43 deletions crates/katana/executor/src/implementation/sir/error.rs

This file was deleted.

Loading
Loading