Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure scarb points to the correct plugin version #2194

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Jul 19, 2024

Summary by CodeRabbit

  • New Features

    • Updated dependency management for improved stability and predictability in builds by transitioning from specific commits to tagged versions for scarb and scarb-ui.
    • Enhanced versioning approach for dojo_plugin to utilize a specific commit reference, ensuring more reliable dependency resolution.
  • Documentation

    • Updated comments to clarify dependencies and their supported versions, guiding future updates.

Copy link

coderabbitai bot commented Jul 19, 2024

Walkthrough

Ohayo, sensei! The recent changes focus on refining dependency management in the project's configuration files. Specifically, the Cargo.toml file transitions from fixed commit references for the scarb and scarb-ui packages to tagged versions, enhancing stability. In the Scarb.toml file, the dependency for dojo_plugin shifts from a branch reference to a specific commit, ensuring more predictable builds and better support for the Cairo version in use.

Changes

Files Change Summary
Cargo.toml Updated scarb and scarb-ui dependencies from specific commit references to tagged versions.
crates/dojo-core/Scarb.toml Changed dojo_plugin dependency from branch reference to specific commit, clarifying compatibility with Cairo version.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Scarb
    participant Dojo

    User->>Scarb: Request Dependency Update
    Scarb->>Scarb: Check Dependencies
    Scarb-->>User: Provide Updated Dependencies
    User->>Dojo: Initiate Dojo Plugin
    Dojo->>Dojo: Resolve Version
    Dojo-->>User: Confirm Plugin Loaded
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d90b52b and 31ff262.

Files ignored due to path filters (3)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo-lang/src/manifest_test_data/compiler_cairo/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • crates/dojo-core/Scarb.toml (1 hunks)
Additional comments not posted (2)
crates/dojo-core/Scarb.toml (1)

9-11: Ohayo, sensei! Great job on improving dependency stability.

Updating the dojo_plugin dependency from a branch reference to a specific commit enhances stability and predictability in the dependency resolution process. The updated comment accurately reflects the current state and future update requirements.

Cargo.toml (1)

175-176: Ohayo, sensei! Excellent move towards stable versioning.

Updating the scarb and scarb-ui dependencies from specific commit references to tagged versions enhances stability and predictability in the dependency resolution process. This approach ensures consistent builds and better integration practices.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@glihm glihm merged commit 729f46f into dojoengine:main Jul 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant