Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dojo-lang): bump to cairo 2.7.0-rc.3 #2189

Merged
merged 33 commits into from
Jul 19, 2024
Merged

fix(dojo-lang): bump to cairo 2.7.0-rc.3 #2189

merged 33 commits into from
Jul 19, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Jul 18, 2024

Description

Bumps Cairo to 2.7.0-rc.3 to catchup with the blockifier.

Summary by CodeRabbit

  • New Features

    • Updated dependencies to the latest versions for improved stability and performance.
  • Refactor

    • Switched from cairo-vm dependency to roaring for better performance in database operations.
  • Chores

    • Added compile-time warnings for unused crate dependencies in non-test scenarios to keep the codebase clean.

Copy link

coderabbitai bot commented Jul 18, 2024

Walkthrough

Ohayo, sensei! The recent updates primarily involve bumping up versions of various cairo-lang dependencies to 2.7.0-rc.3 and cairo-vm to 1.0.0-rc4. Additionally, some dependencies in Scarb.toml within dojo-core have been updated, including changes in branches and versions. The katana storage DB module now uses the roaring dependency and introduces a compile-time warning for unused dependencies in non-test scenarios.

Changes

Files / Paths Summary of Changes
Cargo.toml Updated cairo-lang dependencies to 2.7.0-rc.3 and cairo-vm to 1.0.0-rc4. Scarb and scarb-ui revisions updated.
crates/dojo-core/Scarb.toml Changed cairo-version and starknet to 2.7.0-rc.3, updated dojo_plugin dependency to use bump-cairo-2.7 branch.
crates/katana/storage/db/Cargo.toml Removed cairo-vm dependency and added roaring dependency with specific features.
crates/katana/storage/db/src/lib.rs Added compile-time warning for unused dependencies in non-test scenarios.

No sequence diagrams are necessary for this update since changes are mostly version bumps and dependency adjustments. If you have any questions or need further breakdowns, feel free to ask, sensei!


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between afcd238 and 2777bf6.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (1)
  • crates/katana/storage/db/Cargo.toml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • crates/katana/storage/db/Cargo.toml

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (1d3318a) to head (2777bf6).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/dojo-lang/src/semantics/test_utils.rs 0.00% 2 Missing ⚠️
crates/dojo-world/abigen/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2189      +/-   ##
==========================================
+ Coverage   67.52%   67.53%   +0.01%     
==========================================
  Files         336      336              
  Lines       43980    43986       +6     
==========================================
+ Hits        29699    29708       +9     
+ Misses      14281    14278       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit d90b52b into main Jul 19, 2024
14 of 15 checks passed
@glihm glihm deleted the bump-cairo-2.7 branch July 19, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants