Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump
blockifier
to support Cairo 2.7 #2180Bump
blockifier
to support Cairo 2.7 #2180Changes from 25 commits
a46c723
da1d5e0
bbcb978
58de95e
0dcfddf
67eeb78
6c488c2
22d14c6
013251e
72fbbcf
b17ccac
be99879
d019c76
a6d4e34
c19e325
74c5db1
a674436
a786e57
15e7e06
5009503
8c6bffe
c7d6539
ad83f47
772f55f
603a3c5
40c3b2c
20d50ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, is this
CACHE_SIZE
something that we want to customize at some point, or we shouldn't care more about it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure but they have removed the
GlobalContractCache
when creating a newCachedState
which what we usedCACHE_SIZE
before.this was before:
https://github.com/dojoengine/blockifier/blob/57c115864b5d2e9876efe289bd3dfbf05744a76b/crates/blockifier/src/state/cached_state.rs#L40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they hear you: https://github.com/starkware-libs/blockifier/blob/99ddb927994be44ef333c860d33ecc149e8d4273/crates/blockifier/src/context.rs#L28.