fix(sozo): ensure overlays can support any resource type

[glihm]

This PR enables the use of any resource type into the overlays, to follow the scheme used by sozo auth command.

Summary by CodeRabbit

• Refactor

  • Improved authorization process for better clarity and efficiency.
  • Adjusted UI messages related to resource authorization.

• Bug Fixes

  • Ensured proper handling of contracts and resources in the authorization logic.

[coderabbitai]

Walkthrough

The recent changes in auto_auth.rs focus on refining the authorization logic within the auto_authorize and compute_writers functions. These updates streamline the process by removing ResourceType from the import list and improving the clarity and efficiency of message handling and resource authorization.

Changes

File Path	Summary
...sozo/ops/src/migration/auto_auth.rs	Removed ResourceType from imports and refactored the auto_authorize and compute_writers functions to enhance authorization clarity and efficiency.

Poem

In lines of code where logic sways,
A rabbit hops through endless arrays.
It trims and prunes with careful might,
To make the code both clear and bright.
With ResourceType left far behind,
Efficiency and clarity, now aligned. 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

crates/sozo/ops/src/migration/auto_auth.rs (1)

61-67: Refactor resource type handling for clarity.

The current logic for determining resource_type can be simplified for readability.

- let resource_type = if tag_with_prefix.contains(':') {
-     tag_with_prefix.to_string()
- } else {
-     // Default to model if no prefix was given.
-     format!("m:{}", tag_with_prefix)
- };
+ let resource_type = match tag_with_prefix.contains(':') {
+     true => tag_with_prefix.to_string(),
+     false => format!("m:{}", tag_with_prefix),
+ };

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bbb355e and 6f984ae.

Files selected for processing (1)

• crates/sozo/ops/src/migration/auto_auth.rs (3 hunks)

Additional comments not posted (2)

crates/sozo/ops/src/migration/auto_auth.rs (2)

13-13: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to auto_authorize are updated if the signature has changed.

---

46-51: Verify the existence of contracts.

Ensure that the expect statement correctly handles cases where the contract might not exist. Consider adding more context to the error message for easier debugging.

- .expect("we know this contract exists");
+ .expect("Contract with the specified tag not found in local manifest");

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6f984ae and 1003244.

Files selected for processing (1)

• crates/sozo/ops/src/migration/auto_auth.rs (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• crates/sozo/ops/src/migration/auto_auth.rs

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.00%. Comparing base (bbb355e) to head (ba24b53).
Report is 3 commits behind head on main.

Files	Patch %	Lines
crates/sozo/ops/src/migration/auto_auth.rs	92.30%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   68.00%   68.00%           
=======================================
  Files         331      331           
  Lines       42697    42728   +31     
=======================================
+ Hits        29035    29057   +22     
- Misses      13662    13671    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1003244 and ba24b53.

Files selected for processing (1)

• crates/sozo/ops/src/migration/auto_auth.rs (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• crates/sozo/ops/src/migration/auto_auth.rs