fix(compiler): use provided metadata to support feature flags #2167
Conversation
WalkthroughThe recent changes introduce the Changes
PoemA rabbit hopped through code so grand, Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- bin/sozo/src/commands/mod.rs (1 hunks)
- crates/dojo-lang/src/contract.rs (5 hunks)
- crates/dojo-lang/src/interface.rs (2 hunks)
- crates/dojo-lang/src/plugin.rs (3 hunks)
- crates/katana/storage/provider/src/error.rs (1 hunks)
Files skipped from review due to trivial changes (2)
- bin/sozo/src/commands/mod.rs
- crates/katana/storage/provider/src/error.rs
Additional comments not posted (6)
crates/dojo-lang/src/interface.rs (1)
20-24: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
from_traitmatch the new signature.crates/dojo-lang/src/plugin.rs (3)
115-118: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
handle_modmatch the new signature.
124-131: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
handle_traitmatch the new signature.
Line range hint
343-365:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
generate_codematch the new signature.crates/dojo-lang/src/contract.rs (2)
Line range hint
44-87:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
from_modulematch the new signature.
Line range hint
557-579:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
rewrite_implmatch the new signature.
lambda-0x
force-pushed
the
fix-compiler-metadata
branch
from
a6b6435 to
b10768d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- crates/dojo-lang/src/plugin.rs (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- crates/dojo-lang/src/plugin.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
=======================================
Coverage 67.99% 68.00%
=======================================
Files 331 331
Lines 42686 42697 +11
=======================================
+ Hits 29026 29035 +9
- Misses 13660 13662 +2 ☔ View full report in Codecov by Sentry. |
No description provided.