-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for signed integers #2161
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d5e28cb
feat: add support for signed integers
EjembiEmmanuel 06c5565
chore: run scripts/rust_fmt.sh
EjembiEmmanuel f5f10c6
feat: add support for signed integers
EjembiEmmanuel 0ad393c
chore: run scripts/rust_fmt.sh
EjembiEmmanuel 5947778
Merge branch 'signed-integers' of github.com:EjembiEmmanuel/dojo into…
EjembiEmmanuel 0404110
feat: decode signed integer
EjembiEmmanuel 3bb9810
test: test signed integers decoder
EjembiEmmanuel c6ac6fc
refac: remove redundant type casting
EjembiEmmanuel 40dc003
refac: modify signed integer decoder
EjembiEmmanuel 4d0f5f3
feat: implement try from felt for signed integers
EjembiEmmanuel aa2ea32
Delete scripts/prettier.sh
EjembiEmmanuel 96d5a03
Merge branch 'main' into signed-integers
EjembiEmmanuel 8ca937e
chore: add comments
EjembiEmmanuel 23e9b55
Merge remote-tracking branch 'dojo/main' into signed-integers
glihm 936ba3c
fix: ensure signed integers are correctly printed
glihm 2adfda3
fix: add more tests
glihm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved: Implementation of
SignedIntegerCalldataDecoder
and its tests.The implementation of
SignedIntegerCalldataDecoder
for decoding signed integers from calldata is correctly done. The addition of comprehensive tests for various signed integer types (i8
,i16
,i32
,i64
,i128
) ensures the correctness of the decoder.Consider adopting the suggested refactoring to treat all signed integers as a single
Felt
regardless of their size, which could simplify the code and improve efficiency.Also applies to: 252-295