-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove dbg!
macro
#2131
chore: remove dbg!
macro
#2131
Conversation
WalkthroughThe recent changes involve removal of debug statements ( Changes
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- crates/dojo-world/src/metadata_test.rs (1 hunks)
- crates/torii/grpc/src/server/tests/entities_test.rs (1 hunks)
Files skipped from review due to trivial changes (2)
- crates/dojo-world/src/metadata_test.rs
- crates/torii/grpc/src/server/tests/entities_test.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
- Coverage 68.12% 68.11% -0.02%
==========================================
Files 332 332
Lines 41573 41571 -2
==========================================
- Hits 28322 28316 -6
- Misses 13251 13255 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember seeing this, debug!
should be used instead? Or this may not be used?
wdym? i think ppl just forgot to remove it before merging and its making the tests run output dirty. |
Oh nvm, I mixed it up. Thanks for the good catch. 👍 |
Description
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)Summary by CodeRabbit