Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dbg! macro #2131

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore: remove dbg! macro #2131

merged 1 commit into from
Jul 3, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jul 3, 2024

Description

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Summary by CodeRabbit

  • Bug Fixes
    • Removed unnecessary debug statements to improve performance and reduce clutter in debugging output.

Copy link

coderabbitai bot commented Jul 3, 2024

Walkthrough

The recent changes involve removal of debug statements (dbg!) from several test files in the dojo-world and torii/grpc directories. These modifications focus on eliminating unnecessary debugging outputs without affecting the core functionality or flow of the test functions.

Changes

Files Change Summary
crates/dojo-world/src/metadata_test.rs Removed debug statements for artifacts and dojo_metadata.resources_artifacts variables.
crates/torii/grpc/src/server/tests/entities_test.rs Removed debug statement dbg!(&migration).

Poem

In the world of code, a change so slight,
Debug lines vanished, into the night.
Sleek and clear, they pave the way,
For logic to shine, without display.
🎩🐇✨

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f134883 and 47bc3c9.

Files selected for processing (2)
  • crates/dojo-world/src/metadata_test.rs (1 hunks)
  • crates/torii/grpc/src/server/tests/entities_test.rs (1 hunks)
Files skipped from review due to trivial changes (2)
  • crates/dojo-world/src/metadata_test.rs
  • crates/torii/grpc/src/server/tests/entities_test.rs

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.11%. Comparing base (f134883) to head (47bc3c9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2131      +/-   ##
==========================================
- Coverage   68.12%   68.11%   -0.02%     
==========================================
  Files         332      332              
  Lines       41573    41571       -2     
==========================================
- Hits        28322    28316       -6     
- Misses      13251    13255       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember seeing this, debug! should be used instead? Or this may not be used?

@kariy
Copy link
Member Author

kariy commented Jul 3, 2024

Remember seeing this, debug! should be used instead? Or this may not be used?

wdym? i think ppl just forgot to remove it before merging and its making the tests run output dirty.

@glihm
Copy link
Collaborator

glihm commented Jul 3, 2024

Remember seeing this, debug! should be used instead? Or this may not be used?

wdym? i think ppl just forgot to remove it before merging and its making the tests run output dirty.

Oh nvm, I mixed it up. Thanks for the good catch. 👍

@glihm glihm merged commit 89b8835 into main Jul 3, 2024
15 checks passed
@glihm glihm deleted the remove-dbg branch July 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants