Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(torii-core): update entity timestamp on update #2118

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix(torii-core): update entity timestamp on update #2118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf87b0
fix(torii-core): update entity timestamp on update
Larkooo Jun 28, 2024
158a4ec
chore
Larkooo Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/torii/core/src/sql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ impl Sql {
let keys_str = felts_sql_string(&keys);
let insert_entities = "INSERT INTO entities (id, keys, event_id, executed_at) VALUES (?, \
?, ?, ?) ON CONFLICT(id) DO UPDATE SET \
executed_at=EXCLUDED.executed_at, event_id=EXCLUDED.event_id \
RETURNING *";
updated_at=CURRENT_TIMESTAMP, executed_at=EXCLUDED.executed_at, \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the only location where we should do this fix? Don't we also update them on change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We update them on change there too. We do an upsert which is what the ON CONFLICT is for

event_id=EXCLUDED.event_id RETURNING *";
let mut entity_updated: EntityUpdated = sqlx::query_as(insert_entities)
.bind(&entity_id)
.bind(&keys_str)
Expand Down
Loading