refactor(torii-client): remove storage packed size check #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larkooo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2116 +/- ##
==========================================
- Coverage 68.34% 68.31% -0.03%
==========================================
Files 331 331
Lines 41443 41404 -39
==========================================
- Hits 28323 28286 -37
+ Misses 13120 13118 -2 ☔ View full report in Codecov by Sentry. |
glihm
approved these changes
Jun 28, 2024
| @@ -86,28 +85,6 @@ impl ModelStorage { | |||
| raw_keys: Vec<FieldElement>, | |||
| raw_values: Vec<FieldElement>, | |||
| ) -> Result<(), Error> { | |||
| let model_name = | |||
There was a problem hiding this comment.
We could potentially check that, but only if the layout if Fixed, which means everything is packed as before, hence the values should match.
We can address specific tests for that in an other PR, since related to some changes to the namespace will need test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packed size can now be 0 with the new layout, thus we cannot really trust the packed size to check that the number of provided values is correct. Remvoed the check