Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dojo-bindgen): array length before array items #2060

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Jun 14, 2024

add array length to calldata before adding the serialized array items

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 68.36%. Comparing base (34b13ca) to head (d675fd3).

Files Patch % Lines
crates/dojo-bindgen/src/plugins/unity/mod.rs 36.36% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   68.37%   68.36%   -0.01%     
==========================================
  Files         326      326              
  Lines       40566    40574       +8     
==========================================
+ Hits        27735    27740       +5     
- Misses      12831    12834       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test we can add here or in a subsequent PR? :)

@Larkooo
Copy link
Collaborator Author

Larkooo commented Jun 14, 2024

Any test we can add here or in a subsequent PR? :)

It's a bit hard as it would involve doing a full integration test where we would;

katana & migrate -> compile unity code -> run the c# in some way -> use dojo.c -> check if error from katana 😅

@Larkooo Larkooo merged commit cab4d05 into dojoengine:main Jun 14, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants