Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata update use bytearray #2031

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Jun 6, 2024

deserializes ipfs uri as bytearray

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 49.09091% with 28 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (9e25713) to head (5a091cd).

Files Patch % Lines
crates/dojo-world/src/metadata.rs 45.00% 22 Missing ⚠️
crates/sozo/ops/src/migration/migrate.rs 0.00% 5 Missing ⚠️
...rates/torii/core/src/processors/metadata_update.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
- Coverage   69.13%   69.13%   -0.01%     
==========================================
  Files         318      318              
  Lines       38524    38555      +31     
==========================================
+ Hits        26635    26654      +19     
- Misses      11889    11901      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm changed the title fix: metadataupdate use bytearray fix: metadata update use bytearray Jun 6, 2024
@glihm glihm merged commit 9ea6574 into dojoengine:main Jun 6, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants