feat(sozo): make few argument global #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2029 +/- ##
=======================================
Coverage 69.13% 69.13%
=======================================
Files 318 318
Lines 38524 38524
=======================================
Hits 26633 26633
Misses 11891 11891 ☔ View full report in Codecov by Sentry. |
glihm
reviewed
Jun 4, 2024
| @@ -70,15 +70,15 @@ impl SozoArgs { | |||
| #[derive(Parser, Clone, Debug)] | |||
| #[group(multiple = false)] | |||
| pub struct ProfileSpec { | |||
| #[arg(short = 'P', long)] | |||
| #[arg(short = 'P', long, global = true)] | |||
There was a problem hiding this comment.
We may not have short argument as global to avoid conflicts? Or do you think is is already in use by lot's of people like so, and we should keep it short too?
There was a problem hiding this comment.
yeah i think we should keep both because even scarb uses P as the short version for specifying profile
glihm
approved these changes
Jun 4, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make profile related and offline global so they can be specified anywhere in the argument list