Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dojo-bindgen): 2d+ arrays, bytearrays and enums serialization #2028

Merged
merged 15 commits into from
Jun 13, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Jun 3, 2024

  • handle bytearrays in systems
  • filter systems with ones with no output (to hide internal funcs)
  • add helpers to get index from records

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 71.49758% with 59 lines in your changes missing coverage. Please review.

Project coverage is 68.35%. Comparing base (1fe0488) to head (8e4393b).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/dojo-bindgen/src/plugins/unity/mod.rs 71.49% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   68.41%   68.35%   -0.07%     
==========================================
  Files         323      323              
  Lines       40258    40450     +192     
==========================================
+ Hits        27541    27648     +107     
- Misses      12717    12802      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo marked this pull request as ready for review June 3, 2024 17:25
@Larkooo Larkooo changed the title refactor: handle bytearrays in systems refactor: handle bytearrays in systems & calculate idx of record rust-like enums Jun 3, 2024
@Larkooo Larkooo marked this pull request as draft June 6, 2024 17:31
@glihm glihm added the enhancement New feature or request label Jun 10, 2024
@Larkooo Larkooo marked this pull request as ready for review June 13, 2024 18:29
@Larkooo Larkooo changed the title refactor: handle bytearrays in systems & calculate idx of record rust-like enums feat(dojo-bindgen): 2d+ arrays, bytearrays and enums serialization Jun 13, 2024
@Larkooo Larkooo merged commit 78c88e5 into dojoengine:main Jun 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants