Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to skip migration of certain contracts/models #2026

Merged
merged 18 commits into from
Jun 13, 2024
Merged

Conversation

lambda-0x
Copy link
Contributor

@lambda-0x lambda-0x commented Jun 3, 2024

Description

fix: #1924

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 76.68394% with 45 lines in your changes missing coverage. Please review.

Project coverage is 68.37%. Comparing base (af5be66) to head (f05cbe7).

Files Patch % Lines
bin/sozo/src/commands/migrate.rs 0.00% 14 Missing ⚠️
...ates/dojo-bindgen/src/plugins/typescript_v2/mod.rs 8.33% 11 Missing ⚠️
bin/sozo/src/commands/dev.rs 0.00% 9 Missing ⚠️
crates/dojo-world/src/manifest/mod.rs 58.33% 5 Missing ⚠️
crates/dojo-bindgen/src/lib.rs 96.15% 1 Missing ⚠️
crates/dojo-test-utils/src/migration.rs 75.00% 1 Missing ⚠️
crates/dojo-world/src/contracts/world_test.rs 92.85% 1 Missing ⚠️
crates/dojo-world/src/manifest/manifest_test.rs 98.03% 1 Missing ⚠️
crates/sozo/ops/src/migration/mod.rs 80.00% 1 Missing ⚠️
crates/sozo/ops/src/migration/utils.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
+ Coverage   68.31%   68.37%   +0.05%     
==========================================
  Files         326      326              
  Lines       40424    40566     +142     
==========================================
+ Hits        27616    27737     +121     
- Misses      12808    12829      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x lambda-0x marked this pull request as ready for review June 8, 2024 19:34
@glihm glihm added the sozo label Jun 10, 2024
bin/sozo/src/commands/dev.rs Outdated Show resolved Hide resolved
crates/dojo-bindgen/src/lib.rs Outdated Show resolved Hide resolved
crates/sozo/ops/src/migration/utils.rs Show resolved Hide resolved
examples/spawn-and-move/src/models.cairo Outdated Show resolved Hide resolved
examples/spawn-and-move/src/skipped.cairo Outdated Show resolved Hide resolved
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @lambda-0x! I'm just thinking that we may ignore some of the generated manifests that are not overlays and keep perhaps only the manifest.toml and manifest.json actually.

@glihm glihm merged commit 0b8b0e5 into main Jun 13, 2024
15 checks passed
@glihm glihm deleted the skip-migration branch June 13, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sozo] ability to skip migration for certain contracts
2 participants