Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove typescript v2 causing flaky tests #1985

Closed
wants to merge 3 commits into from

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented May 19, 2024

Description

Test to generate bindings with unity and typescript can be flaky due to the support of ByteArray that is not fully updated yet.
This PR disable for now one test that will be introduced again once bindings are updated.

The reason seemed to be typescript v2 has it's not currently maintain to follow SDK updates.

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (c9714ef) to head (6330ec2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
- Coverage   69.73%   69.69%   -0.04%     
==========================================
  Files         314      314              
  Lines       35631    35644      +13     
==========================================
- Hits        24848    24843       -5     
- Misses      10783    10801      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm changed the title fix: ignore test until ByteArray support and SDKs are updated fix: remove typescript v2 causing flaky tests May 19, 2024
@glihm
Copy link
Collaborator Author

glihm commented May 19, 2024

To investigate further, not seems to be typescript v2 all the time.

@glihm glihm closed this May 19, 2024
@glihm glihm deleted the fix-build branch June 14, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant