Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forge-std submodule in katana #1974

Merged
merged 1 commit into from
May 16, 2024
Merged

Remove forge-std submodule in katana #1974

merged 1 commit into from
May 16, 2024

Conversation

ZaK3939
Copy link
Contributor

@ZaK3939 ZaK3939 commented May 16, 2024

Description

Removed the [submodule "crates/katana/primitives/contracts/messaging/solidity/lib/forge-std"] section from the .gitmodules file.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ZaK3939 and this fix.

Question, is the git issue resolved with this being removed? And you can use sozo init without any problem?

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (9f8147d) to head (d6201cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1974   +/-   ##
=======================================
  Coverage   69.80%   69.80%           
=======================================
  Files         313      313           
  Lines       35527    35527           
=======================================
+ Hits        24799    24801    +2     
+ Misses      10728    10726    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZaK3939
Copy link
Contributor Author

ZaK3939 commented May 16, 2024

yes, sozo init is ok in current branch.
should be removed unused submodule to avoid future same error.

@glihm glihm merged commit faf2eb9 into dojoengine:main May 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants