Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more logic on semver check of Starknet API #1966

Merged
merged 3 commits into from
May 16, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented May 15, 2024

Description

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@glihm glihm added the sozo label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.83%. Comparing base (de3b2e5) to head (17779db).
Report is 4 commits behind head on main.

Files Patch % Lines
bin/sozo/src/commands/migrate.rs 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1966      +/-   ##
==========================================
+ Coverage   69.80%   69.83%   +0.03%     
==========================================
  Files         313      313              
  Lines       35526    35562      +36     
==========================================
+ Hits        24798    24835      +37     
+ Misses      10728    10727       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lambda-0x lambda-0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about using: https://docs.rs/semver/latest/semver/struct.VersionReq.html#method.matches instead of doing that logic manually?

@kariy
Copy link
Member

kariy commented May 15, 2024

wdyt about using: https://docs.rs/semver/latest/semver/struct.VersionReq.html#method.matches instead of doing that logic manually?

+1

@glihm
Copy link
Collaborator Author

glihm commented May 16, 2024

wdyt about using: https://docs.rs/semver/latest/semver/struct.VersionReq.html#method.matches instead of doing that logic manually?

Just modified with the use of matches, very good comment on that. Thanks for it.

@glihm glihm requested a review from lambda-0x May 16, 2024 09:44
Copy link
Contributor

@lambda-0x lambda-0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from above comment LGTM!

@glihm glihm merged commit 543322b into dojoengine:main May 16, 2024
13 checks passed
@glihm glihm deleted the sozo/fix-rpc-detection branch June 14, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants