Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana): include full fee info in primitive receipts #1948

Merged
merged 1 commit into from
May 13, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented May 10, 2024

Include transaction fee information in the receipt types.

this also replace the hardcoding of the price unit in the rpc receipt types which doesn't reflect the actual unit that is being used by the transaction.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 91.20879% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (6dca944) to head (b19f7f2).

Files Patch % Lines
crates/katana/rpc/rpc-types/src/receipt.rs 63.63% 4 Missing ⚠️
crates/katana/rpc/rpc/src/starknet.rs 0.00% 2 Missing ⚠️
crates/katana/executor/src/utils.rs 80.00% 1 Missing ⚠️
crates/katana/primitives/src/receipt.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
+ Coverage   69.69%   69.74%   +0.04%     
==========================================
  Files         314      314              
  Lines       35459    35515      +56     
==========================================
+ Hits        24714    24769      +55     
- Misses      10745    10746       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit d21163e into dojoengine:main May 13, 2024
13 checks passed
@kariy kariy deleted the fix/receipt-fee branch May 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant