Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display contract addresses in sozo migrate plan #1926

Merged
merged 14 commits into from
May 19, 2024

Conversation

stevencartavia
Copy link
Contributor

draft PR for #1908

Copy link
Contributor

@lambda-0x lambda-0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we should print address of contracts, you can see how they are calculated at:

let contract_address =
get_contract_address(self.salt(), base_class_hash, &[], world_address);

crates/sozo/ops/src/migration/migrate.rs Outdated Show resolved Hide resolved
@stevencartavia stevencartavia changed the title draft display contract addresses in sozo migrate plan May 5, 2024
@stevencartavia stevencartavia force-pushed the contract-address-migrate branch 2 times, most recently from 8e10765 to d5a21f3 Compare May 10, 2024 22:46
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (c9714ef) to head (4242512).

Files Patch % Lines
crates/sozo/ops/src/migration/migrate.rs 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1926      +/-   ##
==========================================
+ Coverage   69.73%   69.74%   +0.01%     
==========================================
  Files         314      314              
  Lines       35631    35646      +15     
==========================================
+ Hits        24848    24863      +15     
  Misses      10783    10783              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/sozo/ops/src/migration/migrate.rs Outdated Show resolved Hide resolved
crates/sozo/ops/src/migration/migrate.rs Outdated Show resolved Hide resolved
@lambda-0x
Copy link
Contributor

umm looks like a git merge got messed up, can you please rebase your changes to main branch?

@stevencartavia stevencartavia force-pushed the contract-address-migrate branch from dfd0c10 to 8f0f4d8 Compare May 17, 2024 21:01
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here @stevencartavia!

@glihm glihm merged commit 60e7ded into dojoengine:main May 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants