test(katana): messaging e2e test

[fabrobles92]

Integration testing for messaging between L1 and L2 layers

Closes #1785
Closes DOJ-329

[fabrobles92]

@glihm and @kariy I opened a new PR cause I had a lot of conflicts on the other one due to the changes on the main.

Let's continue here

[kariy]

its looking good so far, i took the liberty to apply some formatting and also moved the code to a different module.

i put some todos that should be addressed as the final part of the testing

[codecov]

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.51%. Comparing base (8a5902b) to head (d1df5f5).

Files	Patch %	Lines
...ates/katana/core/src/service/messaging/ethereum.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   68.51%   68.51%           
=======================================
  Files         329      329           
  Lines       41096    41105    +9     
=======================================
+ Hits        28155    28162    +7     
- Misses      12941    12943    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glihm]

@kariy if you could double confirm this modification. I think it was a typo since the first implem, and never reviewed it since the starknet doc was updated.

Thanks mate. 🙏

[kariy]

i believe including the fee there is already correct, according to these clients:

deoxys:

based on this, seems like the hash is computed differently by on some checkpoints.

https://github.com/KasarLabs/deoxys/blob/82c49acdaa1167bc8dc67a3f6ad3d6856c6c7e89/crates/primitives/transactions/src/compute_hash.rs#L142-L151

pathfinder:

https://github.com/eqlabs/pathfinder/blob/677fd40fbae7b5b659bf169e56f055c59cbb3f52/crates/common/src/transaction.rs#L556

https://github.com/eqlabs/pathfinder/blob/677fd40fbae7b5b659bf169e56f055c59cbb3f52/crates/common/src/transaction.rs#L768-L770

juno:

https://github.com/NethermindEth/juno/blob/d9e64106a3a6d81d217d3c8baf28749f4f0bdd71/core/transaction.go#L561-L569

but madara doesn't include the fee:

https://github.com/keep-starknet-strange/madara/blame/7b405924b5859fdfa24ec33f152e56a97a047e31/crates/primitives/transactions/src/compute_hash.rs#L345-L353

I would assume the official clients are the correct one, but confusingly the docs might not be updated.

[glihm]

I've also based my comment on Madara, but actually interesting that all the others are not including it.
Will ask for a clarification, thanks for pinging this up mate.

[glihm]

Amazing work @fabrobles92 🚀 Thank you for this contribution, and @kariy for the follow up. 🙏