-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[saya] Scheduler #1917
[saya] Scheduler #1917
Conversation
c94fd47
to
43b160d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work guys. 🚀
Some feedback in a first review, will follow with a functional review. 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
- Coverage 69.44% 68.21% -1.23%
==========================================
Files 318 323 +5
Lines 39107 40269 +1162
==========================================
+ Hits 27157 27470 +313
- Misses 11950 12799 +849 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work guys!
Some feedback:
- We should avoid static account as it limits a lot the configuration. Will open an issue to ensure the account can be loaded without being static, which will allow configuration from the command line.
- We should test when two batches are settled one after the other. In some configuration I had some errors when saya was trying to settle a second batch.
- Some modification will be done on Sozo to ease the command line and make the flow easier to run. 👍
Description
A parallel prove scheduler for
saya
. It is using ahttp-prover
to prove multiple blocks in at the same time.Tests
Primarly manual end to 2 tests described here: https://github.com/neotheprogramist/dojo/blob/cairo0-prover/crates/saya/README.md#end-to-end-testing
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)