Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saya] Scheduler #1917

Merged
merged 64 commits into from
Jun 11, 2024
Merged

[saya] Scheduler #1917

merged 64 commits into from
Jun 11, 2024

Conversation

neotheprogramist
Copy link
Collaborator

@neotheprogramist neotheprogramist commented May 3, 2024

Description

A parallel prove scheduler for saya. It is using a http-prover to prove multiple blocks in at the same time.

Tests

Primarly manual end to 2 tests described here: https://github.com/neotheprogramist/dojo/blob/cairo0-prover/crates/saya/README.md#end-to-end-testing

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@glihm glihm added the saya This issue is related to Saya (settlement) label May 15, 2024
@matzayonc matzayonc force-pushed the saya/scheduler branch 2 times, most recently from c94fd47 to 43b160d Compare May 28, 2024 12:27
@neotheprogramist neotheprogramist marked this pull request as ready for review May 30, 2024 10:38
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work guys. 🚀

Some feedback in a first review, will follow with a functional review. 👍

bin/saya/programs/differ.json Outdated Show resolved Hide resolved
bin/saya/src/args/mod.rs Show resolved Hide resolved
crates/dojo-core/src/world.cairo Show resolved Hide resolved
crates/saya/core/Cargo.toml Outdated Show resolved Hide resolved
crates/saya/core/src/dojo_os/mod.rs Outdated Show resolved Hide resolved
crates/saya/core/src/prover/scheduler.rs Outdated Show resolved Hide resolved
crates/saya/core/src/prover/scheduler.rs Outdated Show resolved Hide resolved
crates/saya/core/src/prover/stone_image.rs Outdated Show resolved Hide resolved
crates/saya/core/src/verifier/starknet.rs Outdated Show resolved Hide resolved
examples/spawn-and-move/Scarb.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 32.62928% with 925 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (9205009) to head (4777215).

Files Patch % Lines
bin/saya/src/tests.rs 0.00% 384 Missing ⚠️
crates/saya/core/src/prover/scheduler.rs 0.00% 152 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 116 Missing ⚠️
crates/saya/core/src/prover/extract.rs 0.00% 78 Missing ⚠️
crates/saya/core/src/prover/program_input.rs 86.90% 58 Missing ⚠️
bin/scheduler/src/main.rs 0.00% 53 Missing ⚠️
crates/saya/core/src/prover/loader.rs 0.00% 20 Missing ⚠️
crates/saya/core/src/prover/client.rs 0.00% 15 Missing ⚠️
bin/saya/src/args/mod.rs 50.00% 12 Missing ⚠️
crates/saya/core/src/prover/stone_image.rs 0.00% 10 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1917      +/-   ##
==========================================
- Coverage   69.44%   68.21%   -1.23%     
==========================================
  Files         318      323       +5     
  Lines       39107    40269    +1162     
==========================================
+ Hits        27157    27470     +313     
- Misses      11950    12799     +849     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzayonc matzayonc requested a review from glihm May 31, 2024 12:44
@glihm glihm mentioned this pull request May 31, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work guys!

Some feedback:

  1. We should avoid static account as it limits a lot the configuration. Will open an issue to ensure the account can be loaded without being static, which will allow configuration from the command line.
  2. We should test when two batches are settled one after the other. In some configuration I had some errors when saya was trying to settle a second batch.
  3. Some modification will be done on Sozo to ease the command line and make the flow easier to run. 👍

@glihm glihm merged commit d3c3351 into dojoengine:main Jun 11, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
saya This issue is related to Saya (settlement)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants