Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(torii): don't use feature-only type in non-feature code #1894

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 27, 2024

Create a new SchemaError type to be used in the schema module, and replace the usage of ClientError because it is feature-gated.

Previously running cargo check -p torii would result in error where the ClientError is not found because torii crate doesn't rely on the client feature which the error type is hidden under.

@kariy kariy changed the title refactor(torii): don't use feature-only type in code that is not feature-gated refactor(torii): don't use feature-only type in non-feature code Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.31%. Comparing base (a3587b3) to head (7022ea0).

Files Patch % Lines
crates/torii/grpc/src/types/schema.rs 60.00% 4 Missing ⚠️
crates/torii/grpc/src/client.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
- Coverage   70.31%   70.31%   -0.01%     
==========================================
  Files         315      315              
  Lines       35841    35843       +2     
==========================================
  Hits        25203    25203              
- Misses      10638    10640       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix mate.

@glihm glihm merged commit 19fb8e9 into dojoengine:main Apr 27, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants