Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use e.into() instead of Self::from #1892

Closed
wants to merge 1 commit into from
Closed

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Apr 26, 2024

Use e.into() instead of Self::from for consistency with the rest and less verbose implementation.

@tcoratger tcoratger changed the title Use e.into() instead of Self::from` Use e.into() instead of Self::from Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 70.30%. Comparing base (1000fcd) to head (67f23be).
Report is 11 commits behind head on main.

Files Patch % Lines
...na/executor/src/implementation/blockifier/error.rs 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
+ Coverage   70.26%   70.30%   +0.03%     
==========================================
  Files         313      315       +2     
  Lines       35717    35822     +105     
==========================================
+ Hits        25098    25183      +85     
- Misses      10619    10639      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the use of ::from is intentional here as i prefer its verbosity, and if its about consistency then changing the .into()s to ::from makes more sense here.

as its not really part of the code where consistency gives any clear benefit (if any at all), i will keep them as is. thank you.

@kariy kariy closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants