Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure account defaults to block pending #1891

Merged
merged 1 commit into from
Apr 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions bin/sozo/src/commands/options/account.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use anyhow::{anyhow, Context, Result};
use clap::Args;
use dojo_world::metadata::Environment;
use starknet::accounts::{ExecutionEncoding, SingleOwnerAccount};
use starknet::core::types::FieldElement;
use starknet::core::types::{BlockId, BlockTag, FieldElement};
use starknet::providers::Provider;
use starknet::signers::LocalWallet;

Expand Down Expand Up @@ -50,7 +50,14 @@ impl AccountOptions {

let encoding = if self.legacy { ExecutionEncoding::Legacy } else { ExecutionEncoding::New };

Ok(SingleOwnerAccount::new(provider, signer, account_address, chain_id, encoding))
let mut account =
SingleOwnerAccount::new(provider, signer, account_address, chain_id, encoding);

// The default is `Latest` in starknet-rs, which does not reflect
// the nonce changes in the pending block.
account.set_block_id(BlockId::Tag(BlockTag::Pending));

Ok(account)
}

fn account_address(&self, env_metadata: Option<&Environment>) -> Result<FieldElement> {
Expand Down
18 changes: 13 additions & 5 deletions crates/dojo-test-utils/src/sequencer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use katana_rpc::{spawn, NodeHandle};
use katana_rpc_api::ApiKind;
use starknet::accounts::{ExecutionEncoding, SingleOwnerAccount};
use starknet::core::chain_id;
use starknet::core::types::FieldElement;
use starknet::core::types::{BlockId, BlockTag, FieldElement};
use starknet::providers::jsonrpc::HttpTransport;
use starknet::providers::JsonRpcClient;
use starknet::signers::{LocalWallet, SigningKey};
Expand Down Expand Up @@ -92,13 +92,17 @@ impl TestSequencer {
}

pub fn account(&self) -> SingleOwnerAccount<JsonRpcClient<HttpTransport>, LocalWallet> {
SingleOwnerAccount::new(
let mut account = SingleOwnerAccount::new(
JsonRpcClient::new(HttpTransport::new(self.url.clone())),
LocalWallet::from_signing_key(SigningKey::from_secret_scalar(self.account.private_key)),
self.account.account_address,
chain_id::TESTNET,
ExecutionEncoding::New,
)
);

account.set_block_id(BlockId::Tag(BlockTag::Pending));

account
}

pub fn provider(&self) -> JsonRpcClient<HttpTransport> {
Expand All @@ -115,13 +119,17 @@ impl TestSequencer {
let private_key = account.1.private_key().unwrap();
let address: FieldElement = (*(account.0)).into();

SingleOwnerAccount::new(
let mut account = SingleOwnerAccount::new(
JsonRpcClient::new(HttpTransport::new(self.url.clone())),
LocalWallet::from_signing_key(SigningKey::from_secret_scalar(private_key)),
address,
chain_id::TESTNET,
ExecutionEncoding::New,
)
);

account.set_block_id(BlockId::Tag(BlockTag::Pending));

account
}

pub fn raw_account(&self) -> &TestAccount {
Expand Down
6 changes: 4 additions & 2 deletions crates/katana/executor/tests/fixtures/transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use katana_primitives::genesis::Genesis;
use katana_primitives::transaction::ExecutableTxWithHash;
use katana_primitives::FieldElement;
use starknet::accounts::{Account, Call, ExecutionEncoding, SingleOwnerAccount};
use starknet::core::types::BroadcastedInvokeTransaction;
use starknet::core::types::{BlockId, BlockTag, BroadcastedInvokeTransaction};
use starknet::macros::{felt, selector};
use starknet::providers::jsonrpc::HttpTransport;
use starknet::providers::{JsonRpcClient, Url};
Expand All @@ -28,14 +28,16 @@ pub fn invoke_executable_tx(
let provider = JsonRpcClient::new(HttpTransport::new(Url::try_from(url).unwrap()));
let signer = LocalWallet::from_signing_key(SigningKey::from_secret_scalar(private_key));

let account = SingleOwnerAccount::new(
let mut account = SingleOwnerAccount::new(
provider,
signer,
address.into(),
chain_id.into(),
ExecutionEncoding::New,
);

account.set_block_id(BlockId::Tag(BlockTag::Pending));

let calls = vec![Call {
to: DEFAULT_FEE_TOKEN_ADDRESS.into(),
selector: selector!("transfer"),
Expand Down
9 changes: 7 additions & 2 deletions crates/katana/runner/src/prefunded.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use katana_primitives::chain::ChainId;
use katana_primitives::contract::ContractAddress;
use katana_primitives::genesis::allocation::DevGenesisAccount;
use starknet::accounts::{ExecutionEncoding, SingleOwnerAccount};
use starknet::core::types::{BlockId, BlockTag};
use starknet::providers::jsonrpc::HttpTransport;
use starknet::providers::JsonRpcClient;
use starknet::signers::{LocalWallet, SigningKey};
Expand Down Expand Up @@ -36,12 +37,16 @@ impl KatanaRunner {
debug_assert_eq!(Environment::default().chain_id, ChainId::parse("KATANA").unwrap());
let provider = self.owned_provider();

SingleOwnerAccount::new(
let mut account = SingleOwnerAccount::new(
provider,
signer,
account.0.into(),
chain_id.into(),
ExecutionEncoding::New,
)
);

account.set_block_id(BlockId::Tag(BlockTag::Pending));

account
}
}
Loading