Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana): invalid nonce values set in error #1890

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

Eikix
Copy link
Contributor

@Eikix Eikix commented Apr 26, 2024

  • Modified From<TransactionPreValidationError> for ExecutionError to properly display actual and expected nonce

Fixes #1889

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.37%. Comparing base (5f421e1) to head (3c48fee).
Report is 1 commits behind head on main.

Files Patch % Lines
...na/executor/src/implementation/blockifier/error.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
- Coverage   70.37%   70.37%   -0.01%     
==========================================
  Files         315      315              
  Lines       35766    35766              
==========================================
- Hits        25171    25169       -2     
- Misses      10595    10597       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm added the katana This issue is related to Katana label Apr 26, 2024
Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tarrencev tarrencev changed the title KATANA CONTRIBUTOOOOOOR Modified From<TransactionPreValidationError> for ExecutionError to properly display actual and expected nonce Apr 27, 2024
@tarrencev tarrencev merged commit a16158e into dojoengine:main Apr 27, 2024
10 of 12 checks passed
@kariy kariy changed the title Modified From<TransactionPreValidationError> for ExecutionError to properly display actual and expected nonce fix(katana): invalid nonce values set in error Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
katana This issue is related to Katana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] In NonceError, expected and actual are swapped inside From impl.
4 participants