Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saya] demo #1883

Merged
merged 17 commits into from
May 2, 2024
Merged

[saya] demo #1883

merged 17 commits into from
May 2, 2024

Conversation

neotheprogramist
Copy link
Collaborator

refactored #1834

@glihm glihm added the saya This issue is related to Saya (settlement) label Apr 26, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 65.94203% with 141 lines in your changes are missing coverage. Please review.

Project coverage is 69.77%. Comparing base (6427cdc) to head (0940a57).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/saya/core/src/dojo_os/mod.rs 0.00% 49 Missing ⚠️
crates/saya/core/src/verifier/starknet.rs 0.00% 34 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 32 Missing ⚠️
crates/saya/core/src/verifier/mod.rs 0.00% 8 Missing ⚠️
crates/saya/core/src/prover/client.rs 0.00% 6 Missing ⚠️
bin/saya/src/args/mod.rs 60.00% 4 Missing ⚠️
crates/saya/core/src/prover/mod.rs 0.00% 3 Missing ⚠️
bin/saya/src/args/proof.rs 0.00% 2 Missing ⚠️
crates/dojo-world/abigen/src/main.rs 0.00% 2 Missing ⚠️
crates/saya/core/src/prover/state_diff.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
- Coverage   70.28%   69.77%   -0.51%     
==========================================
  Files         315      316       +1     
  Lines       35864    36294     +430     
==========================================
+ Hits        25206    25325     +119     
- Misses      10658    10969     +311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@neotheprogramist neotheprogramist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@glihm glihm merged commit 8f8bdd3 into main May 2, 2024
10 of 12 checks passed
@glihm glihm deleted the saya/final branch May 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
saya This issue is related to Saya (settlement)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants