Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow ref self until sozo can handle starknet contracts #1879

Merged
merged 4 commits into from
May 1, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Apr 24, 2024

We've disabled the use of ref self into dojo contracts.
However, library like origami was intensively using it. And due to the current situation where sozo can't manage starknet contract (which may require some time), this PR ensures that advanced users can use ref self.

ref self is actually mostly used to ensure functions like emit from starknet plugin can be used. And not to directly modify the system storage on its own.

It is important to consider that dojo systems are meant to be stateless.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.65%. Comparing base (a573198) to head (373320f).
Report is 16 commits behind head on main.

Files Patch % Lines
crates/dojo-lang/src/contract.rs 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   70.29%   69.65%   -0.64%     
==========================================
  Files         313      315       +2     
  Lines       35769    36014     +245     
==========================================
- Hits        25143    25085      -58     
- Misses      10626    10929     +303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 5d9a8d1 into dojoengine:main May 1, 2024
11 of 12 checks passed
@glihm glihm deleted the feat/dojo-contract-ref-self branch June 14, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant