Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dojo-core] use const array for pow2 #1878

Merged
merged 5 commits into from
May 29, 2024
Merged

[dojo-core] use const array for pow2 #1878

merged 5 commits into from
May 29, 2024

Conversation

notV4l
Copy link
Collaborator

@notV4l notV4l commented Apr 24, 2024

this should work with next scarb version and be way cheaper

closes #1859

@glihm glihm added the dojo-core cairo core tasks label Apr 25, 2024
@glihm
Copy link
Collaborator

glihm commented Apr 25, 2024

this should work with next scarb version and be way cheaper

closes #1859

When you say next version, 2.6 or 2.7?

@notV4l
Copy link
Collaborator Author

notV4l commented Apr 25, 2024

this should work with next scarb version and be way cheaper

closes #1859

When you say next version, 2.6 or 2.7?

it works with current scarb nigthly

@glihm
Copy link
Collaborator

glihm commented May 19, 2024

@notV4l this one should now work correctly targeting the storage_layout branch. Will check that during this week and change the base branch. 👍

@notV4l notV4l changed the base branch from main to storage_layout May 20, 2024 11:15
Base automatically changed from storage_layout to main May 23, 2024 23:04
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (61c6f39) to head (9684e27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
+ Coverage   67.49%   67.54%   +0.04%     
==========================================
  Files         318      318              
  Lines       37898    37979      +81     
==========================================
+ Hits        25581    25654      +73     
- Misses      12317    12325       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good anticipation @notV4l, very good optimization.

@glihm glihm merged commit 8cfb0ba into main May 29, 2024
13 checks passed
@glihm glihm deleted the pow2_const branch May 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dojo-core cairo core tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dojo-core] replace fpow fn with const span
2 participants