-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dojo-core] use const array for pow2 #1878
Conversation
When you say next version, |
it works with current scarb nigthly |
@notV4l this one should now work correctly targeting the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 67.49% 67.54% +0.04%
==========================================
Files 318 318
Lines 37898 37979 +81
==========================================
+ Hits 25581 25654 +73
- Misses 12317 12325 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good anticipation @notV4l, very good optimization.
this should work with next scarb version and be way cheaper
closes #1859