-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: start adding support to unsubscribe entity susbcriptions #1857
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
- Coverage 70.14% 70.05% -0.10%
==========================================
Files 315 315
Lines 35607 35657 +50
==========================================
+ Hits 24977 24979 +2
- Misses 10630 10678 +48 ☔ View full report in Codecov by Sentry. |
14988cf
to
b637576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor comment
This PR might be closed in favor of dojoengine/dojo.c#25 which uses a client-side approach to close subscription streams. GRPC Will clean up those afterwards. The problem with the server-side approach is that it adds a bit more complexity than the client-side approach. Doing that server-side involves adding new endpoints for cancelling subscriptions & keeping track of the subscription ID, while the client-side one doesn't have those downsides. The only potential down side is that the subscription cleanup will not be done directly. Only after some time that the stream has closed and gets removed from the GRPC subscriptions |
No description provided.