-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add raw max fee to TransactionsOptions
#1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first start @princeibs!
The next step is to implement the max fee being applied in the implementation of the TransactionExt
trait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to make sure that user shouldn't be able to specify both max_fee_raw
and fee_estimate_multiplier
at the same time. that can be enforced by clap as well a manual check in the trait implementation
Do you know the default behavior of starknet-rs? Because we want to limit that at the command level, no? Or also for the |
i was under impression that EDIT: sorry @princeibs made this change myself since we want to merge this PR ASAP. |
It's all cool @lambda-0x. Is the PR ready to be merged or it needs more any more changes? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
+ Coverage 70.04% 70.27% +0.22%
==========================================
Files 315 313 -2
Lines 35535 35724 +189
==========================================
+ Hits 24891 25105 +214
+ Misses 10644 10619 -25 ☔ View full report in Codecov by Sentry. |
its done @princeibs, thank you for your contribution! |
Closes #1808
Closes DOJ-344